# HG changeset patch # User Axel Prel <axel.prel@xcg-consulting.fr> # Date 1733827674 -3600 # Tue Dec 10 11:47:54 2024 +0100 # Branch 18.0 # Node ID 208dd1f192c5562878b1a1c0d3312121a1e3ff9f # Parent 7e4a9e871c6fac7a9b92f06c85592aa931d4c99b # EXP-Topic preview fix crashing previews diff --git a/models/redner_template.py b/models/redner_template.py --- a/models/redner_template.py +++ b/models/redner_template.py @@ -78,7 +78,6 @@ preview = fields.Binary( string="Preview", - default="New", compute="_compute_preview", help="This is a preview of the template", ) @@ -92,6 +91,7 @@ description = fields.Char( string="Description", + default="New", help="Description of the template", readonly=False, compute="_compute_template", @@ -187,7 +187,15 @@ @api.depends("body", "template_data") def _compute_preview(self): for record in self: + if not record.redner_id: + record.preview = False + continue + response = self.get_preview(record.redner_id) + if not response: + record.preview = False + continue + b64 = base64.b64encode(response.content) record.preview = b64 @@ -197,7 +205,7 @@ return preview except Exception as e: logger.error("Failed to get preview of redner template :%s", e) - return + return False def _to_odoo_template(self, template): """