Skip to content

Fix broken bool in fromsoap: bool('false') != False

Christophe de Vienne requested to merge bitbucket/declined-pr-1 into branch/default

Created originally on Bitbucket by cmcdaniel (Craig McDaniel)

Changesets for this Pull Request have not been imported, because it had been already declined on Bitbucket. Marked as closed by the import user.

In wsmeext/soap/protocol.py:fromsoap(), the 'value = datatype(el.text)' statement assumes that the text will be converted to the datatype. But bool('any string') evaluates to True, including bool('False'), bool('false'), bool('0'), etc...

Merge request reports

Loading