Code QoL found by linters

MetaAnalytic.py

@@ -111,7 +111,7 @@
         # Generate the fields directly into the nmspc.
         all_analytic = []
 
-        for prefix, model_name in list(analytic.items()):
+        for prefix, model_name in analytic.items():
             # Analytic fields
             all_analytic.append((model_name, prefix, "id"))
 

models/analytic_structure.py

@@ -228,7 +228,7 @@
         src_dim = self.get_ordering_dimensions(model)
 
         if dest_model is None or dest_model == model:
-            for slots in list(src_dim.values()):
+            for slots in src_dim.values():
                 for slot in slots:
                     dest_slot = slot
                     add_field()
@@ -236,7 +236,7 @@
         else:
             dest_dim = self.get_ordering_dimensions(dest_model)
 
-            for dimension, slots in list(src_dim.items()):
+            for dimension, slots in src_dim.items():
                 if dimension in dest_dim:
                     dest_slots = dest_dim[dimension]
                     slots_number = len(slots)
@@ -287,10 +287,10 @@
         return {ans.ordering: ans.nd_id.name for ans in self.get_structures(model)}
 
     @api.model
-    def analytic_fields_get(self, model, fields, prefix="a", suffix="id"):
+    def analytic_fields_get(self, model, field_get_ret, prefix="a", suffix="id"):
         """Set the label values for the analytic fields."""
 
         ans_dict = self.get_dimensions_names(model._analytic_name)
 
         regex = r"{pre}(\d+)_{suf}".format(pre=prefix, suf=suffix)
         match_fct = re.compile(regex).search
@@ -291,11 +291,11 @@
         """Set the label values for the analytic fields."""
 
         ans_dict = self.get_dimensions_names(model._analytic_name)
 
         regex = r"{pre}(\d+)_{suf}".format(pre=prefix, suf=suffix)
         match_fct = re.compile(regex).search
-        matches = [_f for _f in map(match_fct, list(fields.keys())) if _f]
+        matches = [_f for _f in map(match_fct, field_get_ret.keys()) if _f]
 
         for match in matches:
             field = match.group(0)
             slot = match.group(1)
@@ -298,8 +298,8 @@
 
         for match in matches:
             field = match.group(0)
             slot = match.group(1)
-            fields[field]["string"] = ans_dict.get(
+            field_get_ret[field]["string"] = ans_dict.get(
                 "{0}".format(slot), "{0}{1}".format(prefix.upper(), slot)
             )
 
@@ -303,7 +303,7 @@
                 "{0}".format(slot), "{0}{1}".format(prefix.upper(), slot)
             )
 
-        return fields
+        return field_get_ret
 
     @api.model
     def analytic_get_view(self, model, view, prefix="a", suffix="id", subfield=None):
@@ -389,7 +389,7 @@
         registry = self.env.registry
         return [
             model
-            for name, model in list(registry.items())
+            for name, model in registry.items()
             if getattr(model, "_analytic", False)
         ]