Skip to content
Snippets Groups Projects
Commit 9559e8b292df authored by Vincent Hatakeyama's avatar Vincent Hatakeyama
Browse files

:sparkles: improve error handling in import_jsonrpc to help finding problems in import file

parent 1e540bc281fb
No related branches found
No related tags found
No related merge requests found
......@@ -7,6 +7,8 @@
import sys
from typing import Callable, Dict, List, Tuple, Union
from odoorpc.error import RPCError
from . import logging_from_verbose, odoo_connect_parser, odoo_login
from .importing import add_importing_file_parsing, extract_info_from_parsed
......@@ -54,6 +56,8 @@
imf_ids = imf.search(
[("model", "=", model), ("name", "=", field_name)]
)
if not imf_ids:
raise Exception("No field {} in {}".format(field_name, model))
return imf.browse(imf_ids)[0]
def _convert_identity(value):
......@@ -157,7 +161,11 @@
write_id = _ref(xmlid, False)
if write_id:
_logger.debug("Write %s (%d)", model, write_id)
o.env[model].write(write_id, values)
try:
o.env[model].write(write_id, values)
except RPCError:
_logger.error("Current values: %s", values)
raise
wrote.append(write_id)
else:
_logger.debug("Creating a %s", model)
......@@ -161,7 +169,11 @@
wrote.append(write_id)
else:
_logger.debug("Creating a %s", model)
created_id = o.env[model].create(values)
try:
created_id = o.env[model].create(values)
except RPCError:
_logger.error("Current values: %s", values)
raise
created.append(created_id)
if xmlid:
_logger.debug(
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment